Skip to content

Conversation

@JustS-js
Copy link
Contributor

No description provided.

@object-Object
Copy link
Owner

Thanks for the contribution! Sorry for the super long response time. I'm ok to merge this in as-is, but I've since made a bunch of changes to the en_us localization. I'm ok with localizing those changes in this PR or putting them in a separate one, whichever you'd prefer. I am planning on releasing 0.3.0 soon, so I likely won't be changing the English strings further.

@JustS-js
Copy link
Contributor Author

JustS-js commented Apr 9, 2025

Great news! I would like to localize those changes in this pr if that's ok, seems as less of a hussle

@JustS-js
Copy link
Contributor Author

Everything is up to date, should be ok to merge now

@object-Object
Copy link
Owner

thanks!
I am seeing a few warnings about missing keys in ru_ru: https://github.com/object-Object/HexDebug/actions/runs/14381833748/job/40449342196?pr=25#step:4:241
two of them are in doc/resources/assets/hexcasting/lang (here), while the rest are missing from base hexdoc (here) and should probably be contributed there instead of in HexDebug.
these all only affect the web book, not the ingame book.

@object-Object object-Object merged commit 991c819 into object-Object:main Apr 13, 2025
3 checks passed
@object-Object
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants